[configdb]: Fixed a bug that leads to the emerging of records with "None" value in redis-db #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one" value in redis-db Particularly, bgp_asn = "None" inside the DEVICE_METADATA|localhost entry leads bgp daemon to crash Signed-off-by: Denis Maslov <[email protected]>
stcheng
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Fixed a bug that leads to the emerging of records with "None" value in redis-db
Particularly, bgp_asn = "None" inside the DEVICE_METADATA|localhost entry
leads bgp daemon to crash
How to verify it:
Load a minigraph without BGP settings. Check DEVICE_METADATA|localhost in redis-db. You mustn't see bgp_asn field.
Or try to add to the config_db.json any other configuration field with the value "null" and check if it has appeared in redis-db.
Signed-off-by: Denis Maslov [email protected]